Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node to version 20 #957

Merged
merged 18 commits into from
Jul 10, 2024
Merged

Upgrade node to version 20 #957

merged 18 commits into from
Jul 10, 2024

Conversation

roshaanbajwa
Copy link
Collaborator

@roshaanbajwa roshaanbajwa commented Jun 6, 2024 •
edited
Loading

Description

  • Upgrade pipelines to use node version 20
  • Update dependancies and relevant syntax
  • Add missing reference images for backstop

Checklist

@frankieroberto
Copy link
Contributor

@roshaanbajwa did upgrading node require all these dependencies to be updated at the same time (which then affected the reference screenshots in the tests)? 😩

@roshaanbajwa
Copy link
Collaborator Author

@roshaanbajwa did upgrading node require all these dependencies to be updated at the same time (which then affected the reference screenshots in the tests)? 😩

The plan was to have a big dependancy update and hopefully a lot of those reference changes can be reverted back soon (because a lot of them seem to be inconsistent)! But parking this work until after tomorrow's release

edwardhorsford
edwardhorsford reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@edwardhorsford edwardhorsford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also want to update the version listed in .nvmrc

frankieroberto
frankieroberto reviewed Jun 28, 2024
View reviewed changes
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
frankieroberto
frankieroberto previously approved these changes Jul 9, 2024
View reviewed changes
@roshaanbajwa roshaanbajwa merged commit 4f60226 into main Jul 10, 2024
2 checks passed
@roshaanbajwa roshaanbajwa deleted the node-20-upgrade branch July 10, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhorsford edwardhorsford edwardhorsford left review comments

@the-nathan-smith the-nathan-smith the-nathan-smith approved these changes

@frankieroberto frankieroberto frankieroberto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roshaanbajwa @frankieroberto @edwardhorsford @the-nathan-smith